Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unused-modules: add flow tests and enhance typescript tests #1905

Closed

Conversation

nicolashenry
Copy link
Contributor

Try to reproduce #1564 :

  • Add tests for flow type imports
  • Remove typescript tests using "babel-eslint" (because resulting types seems to be flow types)
  • Add some missing cases in typescript tests
  • Add some tests for typescript type imports

@coveralls
Copy link

coveralls commented Sep 21, 2020

Coverage Status

Coverage remained the same at 97.906% when pulling a022baf on nicolashenry:feature/enhance-tests into fef718c on benmosher:master.

@ljharb ljharb reopened this Sep 22, 2020
@ljharb
Copy link
Member

ljharb commented Sep 22, 2020

For future reference, just for running tests, you can enable CI on your fork and push to that :-)

Let's keep this open so I can sync it up, if needed, with a different fix PR (best, of course, is if this can be the fix PR!)

@ljharb
Copy link
Member

ljharb commented May 13, 2021

@nicolashenry it'd be great if you could rebase this on latest master :-)

@ljharb ljharb marked this pull request as draft May 13, 2021 06:51
@nicolashenry
Copy link
Contributor Author

I think you already included it in 5ade156 (it seems) so I think I can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants