Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve path to module 'v8' #676

Closed
SkeLLLa opened this issue Nov 24, 2016 · 11 comments · Fixed by renovatebot/renovate#217
Closed

Unable to resolve path to module 'v8' #676

SkeLLLa opened this issue Nov 24, 2016 · 11 comments · Fixed by renovatebot/renovate#217

Comments

@SkeLLLa
Copy link

SkeLLLa commented Nov 24, 2016

Module v8 is built-in, but eslint-plugin-import tries to find it in node_modules.

@ljharb
Copy link
Member

ljharb commented Nov 24, 2016

Interesting - https://nodejs.org/dist/latest-v7.x/docs/api/v8.html seems to be available only in io.js and node 4+.

This seems to be a bug in the resolve package - specifically that https://npmcdn.com/[email protected]/lib/core.json does not contain the string "v8" (which it would need to do conditionally by node version).

I've filed browserify/resolve#112 to address this.

@benmosher
Copy link
Member

thanks @SkeLLLa for the note and @ljharb for the upstream issue!

@benmosher
Copy link
Member

btw, can probably work around this with import/core-modules setting: https://github.com/benmosher/eslint-plugin-import#importcore-modules

@SkeLLLa
Copy link
Author

SkeLLLa commented Nov 28, 2016

@benmosher, thanks. At least for now I just use // eslint-disable-line.

@ljharb
Copy link
Member

ljharb commented Dec 13, 2016

The resolve module will soon be updated to include all the proper core modules; I'll close this when that happens.

@SkeLLLa
Copy link
Author

SkeLLLa commented Dec 13, 2016

Great!

@ljharb
Copy link
Member

ljharb commented Dec 14, 2016

v1.2.0 of resolve is released, and already included in the semver range for eslint-import-resolver-webpack and eslint-import-resolver-node, so this should already work.

I'll push up a commit shortly that bumps the minimum dep versions in both resolvers which will close this issue.

@ljharb ljharb closed this as completed in f3fd43c Dec 14, 2016
@benmosher
Copy link
Member

heads up @SkeLLLa, just published v0.3.0 of the Node resolver with these changes.

@SkeLLLa
Copy link
Author

SkeLLLa commented Dec 15, 2016

@benmosher, great, thanks!

@benmosher
Copy link
Member

agh, realization: probably can't install it since the Node resolver is a dependency of the plugin and is pegged to ^0.2.0... hmm...

@benmosher
Copy link
Member

created #690 to release v2.1.1 of the plugin that would allow it to be installed. stand by for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants