Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62 tests are failing #1780

Closed
manuth opened this issue May 28, 2020 · 3 comments · Fixed by #1791
Closed

62 tests are failing #1780

manuth opened this issue May 28, 2020 · 3 comments · Fixed by #1791

Comments

@manuth
Copy link
Contributor

manuth commented May 28, 2020

As mentioned in issue #1244 I just tried to create a PR for fixing said issue.
Sadly in the current state (without touching anything but just running npm install and npm test) there are 62 unit-tests failing.

That way it's a bit hard for me to tell whether changes made to the project "would" or "would not" cause any harm to the project.

@ljharb
Copy link
Member

ljharb commented May 29, 2020

What OS are you using?

@manuth
Copy link
Contributor Author

manuth commented May 29, 2020

I tried it on Windows 10 (Build 1909) and Docker Images (node:14 and node:10).

That said, I couldn't even build the project using Windows or node:14.

@manuth
Copy link
Contributor Author

manuth commented May 29, 2020

Alright I managed it to get it done using WSL with node v12 installed.
Looks like git for windows doesn't clone symbolic links and instead creates files containing the file-path.

Now all tests pass except for the case sensitivity ones as WSL neither is fully case sensitive nor fully case insensitive (directories are case sensitive while files aren't).

I'll create a separate PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants