Local imports using webpack aliases are being incorrectly identified as separate groups

[cheapsteak]

Using a webpack config using aliases (and eslint-import-resolver-webpack), each import for an internal modules is being treated as a separate "group". With 'newlines-between': 'always-and-inside-groups', they each have to be separated by a new line

resolve: {
  alias: {
    '~': path.resolve(__dirname, 'src'),
  },
},

import React from 'react';

import ComponentA from '~/components/ComponentA'; // [eslint] There should be at least one empty line between import groups (import/order)
import ComponentB from '~/components/ComponentB'; // [eslint] There should be at least one empty line between import groups (import/order)
import ComponentC from '~/components/ComponentC'; // no error

import ComponentD from '~/components/ComponentD'; // no error

Reproduced here: https://github.com/cheapsteak/eslint-import-order-bug-reproduction
Pull locally and check the lint messages for this file - https://github.com/cheapsteak/eslint-import-order-bug-reproduction/blob/master/src/App.js

[fsmaia]

I'm having a different issue, but I think they are related.

In my case, I have some aliases set in webpack, and resolver is properly configured:

resolve: {
  alias: {
    actions: path.join(__dirname, './src/actions'),
    components: path.join(__dirname, './src/components'),
    constants: path.join(__dirname, './src/constants'),
    //...
  },
},

And import/order is configured with:

{
  "groups": ["builtin", "external", "internal", "parent", "sibling", "index"],
  "newlines-between": "always"
}

I'm trying to import a external followed by internal module:

import { createSelector } from 'reselect';

import { MY_CONSTANT_EXAMPLE } from 'constants/my-constant';

However, I'm getting this error:

[eslint] constants/my-constant import should occur before import of reselect (import/order)

The example above works fine if I replace constants with src/constants.

[laugri]

Hi @cheapsteak , did you find a workaround since you ran into this issue ?

[cheapsteak]

Unfortunately not

[doits]

+1 named imports should be all in the internal group

[echenley]

@fsmaia I am having the exact same issue with a constants folder in particular. All of my other internal aliases seem to work.

Edit: looks like import something from 'constants/something' is being identified as 'builtin', rather than 'internal'.

[echenley]

@ljharb It seems like isBuiltIn needs to be updated to check for a resolved path:

https://github.com/benmosher/eslint-plugin-import/blob/master/src/core/importType.js#L24-L28

// import 'fs' - path is null
// import 'constants' - path is '/absolute/path/src/constants' with webpack resolver
export function isBuiltIn(name, settings, path) {
  const base = baseModule(name)
  const extras = (settings && settings['import/core-modules']) || []
  return !path && coreModules[base] || extras.indexOf(base) > -1
}

[ljharb]

@echenley a PR with a test case would be appreciated :-)

[ljharb]

Now that #1297 is merged, is there anything left to do here?

[echenley]

I believe this can be closed.