From 2e22613790b063eed2ecebd06c217c23be7b77db Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Wed, 30 Mar 2022 15:57:12 -0400 Subject: [PATCH] add changelog Signed-off-by: Sebastian Malton --- CHANGELOG.md | 1 + src/rules/no-cycle.js | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3102fc8691..d778bf4077 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange - [Docs] make rule doc titles consistent ([#2393], thanks [@TheJaredWilcurt]) - [Docs] `order`: TS code examples should use TS code blocks ([#2411], thanks [@MM25Zamanian]) - [Docs] `no-unresolved`: fix link ([#2417], thanks [@kylemh]) +- [Refactor] `no-cycle`: Improve performance by using caching ([#2419], thanks [@nokel81]) ## [2.25.4] - 2022-01-02 diff --git a/src/rules/no-cycle.js b/src/rules/no-cycle.js index 809cfde669..e76b889574 100644 --- a/src/rules/no-cycle.js +++ b/src/rules/no-cycle.js @@ -44,7 +44,6 @@ module.exports = { }, _traversed: traversed, create: (context) => { - // const traversed = new Set(); const myPath = context.getPhysicalFilename ? context.getPhysicalFilename() : context.getFilename(); if (myPath === '') return {}; // can't cycle-check a non-file