Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze: avoid rewriting structs mentioned in extern declarations #948

Closed
spernsteiner opened this issue Jun 9, 2023 · 0 comments · Fixed by #960
Closed

analyze: avoid rewriting structs mentioned in extern declarations #948

spernsteiner opened this issue Jun 9, 2023 · 0 comments · Fixed by #960
Assignees
@aneksteind

Comments

@spernsteiner
Copy link
Collaborator

Structs like FILE, which are used in external libc functions like fwrite, should have their fields marked FIXED so we don't try to rewrite them. Even changing pointers to &/&mut should be forbidden, even though it doesn't change the layout, because the correctness of that change depends on details of the behavior of the libc functions that use the type.
@aneksteind aneksteind self-assigned this Jun 13, 2023
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
a2215ba 
Fixes an issue where we would rewrite structs and their fields
even when they appears in extern blocks.
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
03cc68e 
Fixes an issue where we would rewrite structs and their fields
even when they appears in extern blocks.
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
a009e61 
Fixes an issue where we would rewrite structs and their fields
even when they appears in extern blocks.
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
5b0bfb5 
Fixes an issue where we would rewrite structs and their fields
even when they appears in extern blocks.
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
a1cc1c2 
Fixes an issue where we would rewrite structs and their fields
even when they appears in extern blocks.
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
616cd8d 
Fixes an issue where we would rewrite structs and their fields
even when they appears in extern blocks.
@aneksteind aneksteind mentioned this issue Jun 14, 2023
Merged
@aneksteind aneksteind linked a pull request Jun 14, 2023 that will close this issue
Do not rewrite ADTs mentioned in extern blocks #960
Merged
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
97bbed5 
Fixes an issue where we would rewrite structs and their fields
even though they appear in extern blocks.
aneksteind added a commit that referenced this issue Jun 14, 2023
@aneksteind
Addresses #948
b90b646 
Fixes an issue where we would rewrite structs and their fields
even though they appear in extern blocks.
aneksteind added a commit that referenced this issue Jun 16, 2023
@aneksteind
Do not rewrite ADTs mentioned in extern blocks (#960)
f86d7e4 
Fixes #948. Fixes an issue where we would rewrite structs and their
fields even though they appear in extern blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aneksteind aneksteind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not rewrite ADTs mentioned in extern blocks immunant/c2rust
2 participants
@spernsteiner @aneksteind