Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Comments #707

Closed
PixelJonas opened this issue Sep 17, 2022 · 2 comments
Closed

[Feature]: Comments #707

PixelJonas opened this issue Sep 17, 2022 · 2 comments

Comments

@PixelJonas
Copy link
Contributor

Feature detail

Add a feature, so people can Like and Comment on photos in a shared album.

Platform

Mobile App

@palitu
Copy link

palitu commented Sep 21, 2022

as an addition to this, i see this working in this manner:

  1. A comment, like or tag is added to a photo, via the WebUI or App
  2. The details are embedded in the photo's meta-data
    2.1 The details written should be easily identifiable that they were written by immich (ie, tag is immich/<tag details>, comment is immich-<comment string>)
    2.2 when displaying these details the immich- prefix is hidden.
  3. The details are recorded/sync'd into the DB (for speed of searching)

These are then utilised in the following way:

Comments

  • Are visible under the
    • thumbnail
    • image
    • image information panel
  • Comments are searchable

Liked

  • shown in the image thumbnails
  • shown in the title bar of the image
  • can be filtered for all likes (a logical album)
  • can be used as a search criteria (ie liked AND tree)

Tags

  • shown in title bar of image
  • shown in info bar of image
  • can be filtered for an individual/set of tags (ie, logical albums)
  • can be used as a search criteria

To be honest, this is one of the massive things that myself and my friends are chasing to round out our requirements for a photo viewer/backup/manager, and it will make it infinitely more useful as a catch all photo manager for us.

@palitu
Copy link

palitu commented Sep 21, 2022

note, as far as the ML type automated tagging, it would be good if these are also embedded in the image, but also under a prefix.

The reason for the prefix is to track where the data comes from, and to be able to cleanse it out automatically if desired.

@immich-app immich-app locked and limited conversation to collaborators Feb 8, 2023
@alextran1502 alextran1502 converted this issue into discussion #1660 Feb 8, 2023
@github-project-automation github-project-automation bot moved this from 🚧 Tasks to ✅ Done in Immich Development Feb 8, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants