Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Prevent duplicate photos while logged in from two devices #404

Closed
hyperstown opened this issue Jul 30, 2022 · 6 comments · Fixed by #525 or #557
Closed

[Feature] Prevent duplicate photos while logged in from two devices #404

hyperstown opened this issue Jul 30, 2022 · 6 comments · Fixed by #525 or #557

Comments

@hyperstown
Copy link

hyperstown commented Jul 30, 2022

Feature detail
When user uses one account on two different phones and both devices have same photo, app doesn't recognize that photo from one device has already been uploaded and uploads it from both phones creating duplicate.
It's rather undesired behavior since I'd like to have some photos on both phone while keeping one backup.
I did quick sha256sum check and both photos have exactly the same hash.

How it works now
Steps to reproduce the behavior:

  1. Create account
  2. Log in and enable backup on phone 1
  3. Log in and enable backup on phone 2
  4. Download some photo from the Internet on phone 1 then on phone 2
    (Photos from both are uploaded as unique files)

Expected behavior
A photo has been uploaded from device 1. So it doesn't uploads again from device 2

@alextran1502
Copy link
Contributor

This is not a bug, there is no mechanism for deduplication on the server yet. As long as the photo/video is backed up from different devices, it will be treated as a unique file.

Deduplication on the server side is on the roadmap and will be worked on

@hyperstown
Copy link
Author

Thanks for fast reply. I'll change it to feature request then. Is that ok?

@alextran1502
Copy link
Contributor

Yes, that should be fine. Thank you

@hyperstown hyperstown changed the title [BUG] Duplicate photos while logged in from two devices [Feature] Prevent duplicate photos while logged in from two devices Jul 30, 2022
@hyperstown
Copy link
Author

Small rephrasing: done!
As for labels I don't have permissions.

@alextran1502 alextran1502 added feature and removed bug labels Jul 30, 2022
@MalteKiefer
Copy link
Contributor

@alextran1502 since you save the filename to the database, it should be easy.
We just need to add an API Endpoint to check if the data exists. Then we must update the uploader (mobil/web/cli) to check the endpoint instead of the server folder for existing images.

@Nonobis
Copy link

Nonobis commented Aug 4, 2022

Same as my 2 previous issues for me ... using name is not safe ...

#248
#185

@panoti panoti linked a pull request Aug 29, 2022 that will close this issue
2 tasks
@panoti panoti linked a pull request Aug 31, 2022 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants