Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OAuth login #33

Closed
vins345 opened this issue Feb 25, 2022 · 8 comments
Closed

Add support for OAuth login #33

vins345 opened this issue Feb 25, 2022 · 8 comments

Comments

@vins345
Copy link

vins345 commented Feb 25, 2022

Only login and password is to weak secure for 2022 year :)

@n1ckoates
Copy link

n1ckoates commented Mar 29, 2022

Support for security keys would also be great, if it's not too much of a hassle.

@adyanth
Copy link

adyanth commented Mar 29, 2022

I would say instead of rolling your own, it is better to add OAuth2.0/OIDC support and let the identity providers/auth servers like Authelia or KeyCloak do that job of handling users/rules/2FA/security keys etc.

Username and password is indeed weak for 2022 :)

@alextran1502
Copy link
Contributor

@adyanth Thank man, I like this approach. I will look into incorporating them into the application.

@erikthegamer1242
Copy link

I would say instead of rolling your own, it is better to add OAuth2.0/OIDC support and let the identity providers/auth servers like Authelia or KeyCloak do that job of handling users/rules/2FA/security keys etc.

Username and password is indeed weak for 2022 :)

Please implement Authelia and KeyCloack they are the kings when it comes to self-hosted 2FA

@adyanth
Copy link

adyanth commented Mar 31, 2022

With OIDC in place, it should work with both of them and many many more :)

@ippocratis
Copy link

ippocratis commented Mar 31, 2022

I just finished setting up caddy-security plugin
It does not require any integtagration in the immich side
You just reverse proxy to the imich port on localhost and authorise it with mfa

Reference config

I realised what I just wrote was untrue

Immich app still needs a way to pass the 2fa pin

@alextran1502
Copy link
Contributor

The work is being carried on in #207 - Closing this issue

Repository owner moved this from Todo to Done in Immich Jun 12, 2022
@alextran1502 alextran1502 moved this from Done to In Progress in Immich Jun 20, 2022
@alextran1502 alextran1502 reopened this Jun 20, 2022
@alextran1502 alextran1502 removed the status in Immich Jul 13, 2022
@bo0tzz bo0tzz changed the title Add support for 2FA Authentication Add support for OAuth login Sep 7, 2022
@jrasm91
Copy link
Contributor

jrasm91 commented Nov 21, 2022

Implemented in #884, #990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants