Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot favourite photos from shared album #2977

Closed
2 of 3 tasks
uhthomas opened this issue Jun 26, 2023 · 2 comments
Closed
2 of 3 tasks

cannot favourite photos from shared album #2977

uhthomas opened this issue Jun 26, 2023 · 2 comments
Assignees

Comments

@uhthomas
Copy link
Member

uhthomas commented Jun 26, 2023

The bug

To reproduce:

  1. Create a shared album with photos.
  2. Try to favourite a photo from the shared album (as a sharee).

image

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.64.0

Version of Immich Mobile App

1.63.0 build.103

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

@uhthomas uhthomas changed the title mobile: cannot favourite photos from shared album cannot favourite photos from shared album Jun 26, 2023
@uhthomas
Copy link
Member Author

uhthomas commented Jul 3, 2023

We spoke a bit and I think the best solution here is to create a new "favourites" table which contains an asset id and a user id. This should allow for favourites to be recorded as desired.

@uhthomas uhthomas self-assigned this Jul 3, 2023
@jrasm91
Copy link
Contributor

jrasm91 commented Nov 23, 2023

This bug has been fixed and we can track favorite non owned assets separately. I believe there are discussions about this in GitHub already

@jrasm91 jrasm91 closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants