Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘Load original image’ not working on mobile #10556

Closed
1 of 3 tasks
jaisinghdhaliwal opened this issue Jun 22, 2024 · 16 comments · Fixed by #11786
Closed
1 of 3 tasks

‘Load original image’ not working on mobile #10556

jaisinghdhaliwal opened this issue Jun 22, 2024 · 16 comments · Fixed by #11786

Comments

@jaisinghdhaliwal
Copy link

jaisinghdhaliwal commented Jun 22, 2024

The bug

I think one of the new updates must have broken this. Opening an image always shows the large thumbnail even with ‘load original image’ enabled. This used to work before but appears to have been broken. Tested on iPhone 15 Pro Max and iPad Pro.

The OS that Immich Server is running on

Linux Mint

Version of Immich Server

1.106.2

Version of Immich Mobile App

1.106.3 build.160

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Enable Settings>AssetViewer>LoadOriginalImage
2. Restart app (optional)
3. Open image and zoom in to see extremely heavy compression
4. Can download original image and see that the quality is much better
...

Relevant log output

No response

Additional information

This is a feature that I know for certain was working in a previous version but one of the iOS app updates much have broken it.

@bo0tzz
Copy link
Member

bo0tzz commented Jun 23, 2024

When you reproduce this, what do the app's logs say?

@jaisinghdhaliwal
Copy link
Author

When you reproduce this, what do the app's logs say?

I have app logging set to finest and turned on troubleshooting. I open the app and the logs seem to bring up “Local album XXXXXX has not changed. Skipping sync” and other clean ups and socket opens. I clear the log and tap on multiple images. Nothing gets added to the log.

@fabianbees
Copy link

fabianbees commented Jun 29, 2024

This bug is NOT specific to iOS, it is also reproducable on Android 14. (For me, there is also nothing obvious in the logs.)

@jaisinghdhaliwal jaisinghdhaliwal changed the title ‘Load original image’ not working on iOS ‘Load original image’ not working on mobile Jun 29, 2024
@alextran1502
Copy link
Contributor

Looks like this functionality was removed in #7016

@jaisinghdhaliwal
Copy link
Author

Looks like this functionality was removed in #7016

Could functionality be restored? For now, 'Load original image' seems to be a toggle that doesn't serve any purpose. Could toggling 'Load Original Image' use the 'original_image_loader' that was removed in that commit?

@omeryagmurlu
Copy link

This is probably also the reason behind #9628

@wlamers
Copy link

wlamers commented Jul 12, 2024

Same here #11048

@MK73DS
Copy link

MK73DS commented Jul 16, 2024

I have the opposite issue for local images. I don't want the original to be displayed but the medium one from the server (because some are 100 to 200MPx and make the whole app lag and freeze). But no matter how I change the settings in the Asset Viewer section and clear cache, it stays the same.
If this is a separate issue I will open a new issue but I think it's related to this one and the setting doesn't work as expected?

@Danilado
Copy link

I have the opposite issue for local images. I don't want the original to be displayed but the medium one from the server (because some are 100 to 200MPx and make the whole app lag and freeze). But no matter how I change the settings in the Asset Viewer section and clear cache, it stays the same. If this is a separate issue I will open a new issue but I think it's related to this one and the setting doesn't work as expected?

I had a talk in discord about that. Apparently the load original image functionality was removed to prevent the lag/freeze issue
But I guess it still occurs if you have the original photos on your device

@jaisinghdhaliwal
Copy link
Author

I have the opposite issue for local images. I don't want the original to be displayed but the medium one from the server (because some are 100 to 200MPx and make the whole app lag and freeze). But no matter how I change the settings in the Asset Viewer section and clear cache, it stays the same. If this is a separate issue I will open a new issue but I think it's related to this one and the setting doesn't work as expected?

This is also very confusing because for local images. Local images appears to have a lower resolution than the same local image when viewed in the iOS photos app. I’ve attached 2 screenshots to show my point - one screenshot is an image zoomed in on the native photos app, the other is the same photo zoomed into the same level on Immich (the same local file).
IMG_5017
IMG_5018

@jaisinghdhaliwal
Copy link
Author

I have the opposite issue for local images. I don't want the original to be displayed but the medium one from the server (because some are 100 to 200MPx and make the whole app lag and freeze). But no matter how I change the settings in the Asset Viewer section and clear cache, it stays the same. If this is a separate issue I will open a new issue but I think it's related to this one and the setting doesn't work as expected?

Also for this option, you can go to advanced and select prefer remote images, that way it always loads the thumbnail from the server.

@MK73DS
Copy link

MK73DS commented Jul 17, 2024

Also for this option, you can go to advanced and select prefer remote images, that way it always loads the thumbnail from the server.

The thumbnail is fine. The issue is when I view the photo. It loads the local image (which can be arbitrarily large) instead of the medium sized one from the server as I selected in the settings.
It's not really a deal breaker sure, but the app freezes for 5 to 10 seconds when loading very large images even if they're locally stored.

This is also very confusing because for local images. Local images appears to have a lower resolution than the same local image when viewed in the iOS photos app. I’ve attached 2 screenshots to show my point - one screenshot is an image zoomed in on the native photos app, the other is the same photo zoomed into the same level on Immich (the same local file).

I don't think I noticed a quality drop when zooming on local image. Are you sure the image you are seeing in Immich isn't the medium one from the server?
Also I should have noticed I'm using the Android app, if this matters.

I had a talk in discord about that. Apparently the load original image functionality was removed to prevent the lag/freeze issue But I guess it still occurs if you have the original photos on your device

Did you get an answer? Is that a separate issue from this one? If it is, I would like to open a new issue instead of polluting this one.

@jaisinghdhaliwal
Copy link
Author

jaisinghdhaliwal commented Jul 17, 2024

The thumbnail is fine. The issue is when I view the photo. It loads the local image (which can be arbitrarily large) instead of the medium sized one from the server as I selected in the settings. It's not really a deal breaker sure, but the app freezes for 5 to 10 seconds when loading very large images even if they're locally stored.

By selecting that option, it is supposed to load the large thumbnail image when you open the image regardless of whether the file is also saved locally, for me it is working as intended.

I don't think I noticed a quality drop when zooming on local image. Are you sure the image you are seeing in Immich isn't the medium one from the server? Also I should have noticed I'm using the Android app, if this matters.

Yes I am sure it is the local file as the quality of the large thumbnail preview is much worse than what I showed - I can see this when I have prefer remote images enabled. The local image in the Immich app appears to be a lower resolution version of the local image whereas the remote image is lower resolution AND heavily compressed.

Edit: Below is the remote version of the image that I used before (with prefer remote image enabled), showing that the local image that it is showing is not the remote one and that the quality of local images just displayed worse than the native app.

IMG_5021

@MK73DS
Copy link

MK73DS commented Jul 17, 2024

By selecting that option, it is supposed to load the large thumbnail image when you open the image regardless of whether the file is also saved locally, for me it is working as intended.

Yes, but it also loads every thumbnail from the server as well. Since my Immich library is 100% photos from my phone, I think this is unnecessary. It's a workaround for this issue, but it doesn't solve it.

Yes I am sure it is the local file as the quality of the large thumbnail preview is much worse than what I showed - I can see this when I have prefer remote images enabled. The local image in the Immich app appears to be a lower resolution version of the local image whereas the remote image is lower resolution AND heavily compressed.

Edit: Below is the remote version of the image that I used before (with prefer remote image enabled), showing that the local image that it is showing is not the remote one and that the quality of local images just displayed worse than the native app.

Maybe this is iOS specific? I am not familiar at all with Apple devices I'm sorry. I definitely don't get this behavior on my device.

@omeryagmurlu
Copy link

Is the team aware of this bug? I don’t understand how this bug is not one of the top priority bugs right now?

Not being able to show the images uploaded to it is a bad spot to be in as an image management application in my opinion.

@bo0tzz
Copy link
Member

bo0tzz commented Aug 14, 2024

@omeryagmurlu I'm not sure what you mean, the image is still displayed, just not the full-size original.

Trying to decide priorities for a team you're not a part of is generally considered bad form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants