Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duration encoding/parsing #190

Open
Bronsa opened this issue Nov 3, 2022 · 1 comment
Open

remove duration encoding/parsing #190

Bronsa opened this issue Nov 3, 2022 · 1 comment
Assignees
@c-cube @ewenmaclean

Comments

@Bronsa
Copy link
Member

Bronsa commented Nov 3, 2022 •
edited
Loading

They are to be a purely model type, so no encoding/parsing necessary for FIX

Blocked by imandra-ai/ipl#1240
@Bronsa Bronsa assigned Bronsa, c-cube and ewenmaclean and unassigned Bronsa Nov 3, 2022
@Bronsa
Copy link
Member Author

Bronsa commented Nov 7, 2022

note: briefly discussed with @ewenmaclean and @c-cube, the current use of duration to represent FIX's tenor is not good, we should have a custom tenor type implemented as a sum type, and the encoding/parsing of duration should not be conflated with this

@Bronsa Bronsa changed the title duration encoding/parsing is broken duration encoding/parsing should operate in terms of spans, not be conflated with FIX tenors Nov 7, 2022
@Bronsa Bronsa changed the title duration encoding/parsing should operate in terms of spans, not be conflated with FIX tenors remove duration encoding/parsing Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-cube c-cube

@ewenmaclean ewenmaclean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bronsa @c-cube @ewenmaclean