Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to image::math::Rect #647

Closed
wants to merge 5 commits into from
Closed

Switch to image::math::Rect #647

wants to merge 5 commits into from

Conversation

ripytide
Copy link
Member

@ripytide ripytide commented May 26, 2024 •
edited
Loading

Fixes #645

I moved all the current inherent methods to a RectExt helper trait since the upstream Rect doesn't have those methods, yet.

@ripytide ripytide mentioned this pull request May 30, 2024
Merged
@theotherphil
Copy link
Contributor

Thanks for the PR.

All of the draw_x functions accept inputs that may be extend outside the image and then only draw the points that are within the image bounds. This is a bit odd if you think of the image as a finite canvas but makes more sense for the original use case for several of these functions which was to annotate photos/video frames with areas of interest identified using these images.

I’d rather keep the consistency between these functions so won’t merge this PR.

@ripytide ripytide mentioned this pull request Jun 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch imageproc::Rect to image::Rect
2 participants
@ripytide @theotherphil