Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/widget for titles #910

Merged
merged 21 commits into from
Mar 24, 2022
Merged

Feature/widget for titles #910

merged 21 commits into from
Mar 24, 2022

Conversation

imaNNeo
Copy link
Owner

@imaNNeo imaNNeo commented Feb 18, 2022

Allow to return a Widget in SideTitles . getTitles instead of a String. For example, you can pass an Icon widget as a title.

#183.

LineSample8:
line_chart_sample_8

BarSample7:

  • Rename axisName to axisNameWidget
  • Rename getTitles to getTitlesWidget
  • Write migration guideline
  • Implement some samples
  • Write needed unit tests

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #910 (f1f6d94) into master (7d403b5) will increase coverage by 2.61%.
The diff coverage is 94.26%.

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   82.39%   85.01%   +2.61%     
==========================================
  Files          35       42       +7     
  Lines        3005     2716     -289     
==========================================
- Hits         2476     2309     -167     
+ Misses        529      407     -122     
Impacted Files Coverage Δ
lib/src/chart/bar_chart/bar_chart.dart 0.00% <0.00%> (ø)
lib/src/chart/line_chart/line_chart.dart 0.00% <0.00%> (ø)
lib/src/chart/pie_chart/pie_chart_painter.dart 100.00% <ø> (+17.91%) ⬆️
lib/src/chart/radar_chart/radar_chart_painter.dart 100.00% <ø> (+4.91%) ⬆️
lib/src/chart/scatter_chart/scatter_chart.dart 0.00% <0.00%> (ø)
lib/src/utils/utils.dart 100.00% <ø> (+10.61%) ⬆️
lib/src/chart/line_chart/line_chart_painter.dart 82.61% <83.58%> (+1.20%) ⬆️
lib/src/chart/bar_chart/bar_chart_painter.dart 93.88% <89.47%> (+1.60%) ⬆️
.../src/chart/base/axis_chart/axis_chart_painter.dart 98.88% <94.73%> (+1.25%) ⬆️
.../base/axis_chart/side_titles/side_titles_flex.dart 97.60% <97.60%> (ø)
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@imaNNeo imaNNeo force-pushed the dev branch 2 times, most recently from 37fb6f1 to 711c937 Compare March 3, 2022 20:46
@imaNNeo imaNNeo force-pushed the feature/widget-for-titles branch from c6f1ee8 to 918fe6e Compare March 6, 2022 22:36
Base automatically changed from dev to master March 11, 2022 19:57
@imaNNeo imaNNeo force-pushed the feature/widget-for-titles branch 9 times, most recently from a8666cf to fc23d16 Compare March 24, 2022 07:19
@imaNNeo imaNNeo force-pushed the feature/widget-for-titles branch from fc23d16 to 4d3ef6f Compare March 24, 2022 08:39
@imaNNeo imaNNeo force-pushed the feature/widget-for-titles branch from 4d3ef6f to 76eb4e3 Compare March 24, 2022 13:26
@imaNNeo imaNNeo force-pushed the feature/widget-for-titles branch from 9527dd9 to a6a0d49 Compare March 24, 2022 18:12
@imaNNeo imaNNeo merged commit c75f432 into master Mar 24, 2022
@imaNNeo imaNNeo deleted the feature/widget-for-titles branch March 24, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant