Bar graphs draw below the bottom axis when minY is set

[blough]

When using a bar graph, if the minY value is set on the BarGraphData then the bars draw below the bottom axis covering the titles.

The can be reproduced with the example application. Open the file bar_chart_sample3.dart and add minY: 5 at line 21 (just above the line maxY: 20).

Here is how it looks without a maxY value set

Here is how it looks with a maxY set to 5

Flutter 1.17.5
FlChart 0.11.0

Thank you for a great library!

[blough]

Would it work to change lines 209 and 237 of bar_chart_painter.dart (https://github.com/imaNNeoFighT/fl_chart/blob/master/lib/src/chart/bar_chart/bar_chart_painter.dart#L237) from

final bottom = getPixelY(0, drawSize);
to
final bottom = getPixelY(max(data.minY ?? 0, 0), drawSize);

to fix the issue?

[imaNNeo]

Hi, sorry for the late answer,
you are exactly correct, and you got it.
Make a PR and fix it by yourself :)
Also, you should fix this issue for the negative values too (check line 247 too)
Thanks for reporting and contributing.
Cheers!

[imaNNeo]

And thanks for your great explanation.

[ulusoyca]

@imaNNeoFighT Thanks for the answer. Looks like our project is blocked by this issue. Do you have any updates?

[imaNNeo]

Okay,
I'm on it :)

[imaNNeo]

Sorry for the delay, fixed in 0.11.1,
check it out.

Thanks for reporting and contributing.

[ulusoyca]

@imaNNeoFighT Thanks for the effort. Much appreciated!