From 4f6e68be54b18f62ef340a85c32a37188d69eb06 Mon Sep 17 00:00:00 2001 From: Danielle Adams Date: Wed, 6 Sep 2023 15:22:40 -0600 Subject: [PATCH] ARCH-1916 - Update increment run-name and add clarification on code inputs. --- .github/workflows/build-and-review-pr.yml | 2 ++ .github/workflows/increment-version-on-merge.yml | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-review-pr.yml b/.github/workflows/build-and-review-pr.yml index f1274eb..7505959 100644 --- a/.github/workflows/build-and-review-pr.yml +++ b/.github/workflows/build-and-review-pr.yml @@ -49,11 +49,13 @@ jobs: # The files that contain source code for the action. Only files that affect the action's execution # should be included like action.yml or package.json. Do not include files like README.md or .gitignore. # Files do not need to be explicitly provided here if they fall under one of the dirs in dirs-with-code. + # The format of this input is a comma-separated string. # ** This value must match the same files-with-code argument specified in increment-version-on-merge.yml. files-with-code: 'action.yml,package.json,package-lock.json' # TODO: Update if there are additional files or scripts. # The directories that contain source code for the action. Only dirs with files that affect the action's # execution should be included like src or dist. Do not include dirs like .github or node_modules. + # The format of this input is a comma-separated string. # ** This value must match the same dirs-with-code argument specified in increment-version-on-merge.yml. dirs-with-code: 'src,dist' # TODO: Update if there are additional directories with code for the action. diff --git a/.github/workflows/increment-version-on-merge.yml b/.github/workflows/increment-version-on-merge.yml index aa5b41c..7544936 100644 --- a/.github/workflows/increment-version-on-merge.yml +++ b/.github/workflows/increment-version-on-merge.yml @@ -1,5 +1,5 @@ name: Increment Version on Merge -run-name: 'Increment Version for PR #${{ github.event.pull_request.number }}' +run-name: "${{ github.event.pull_request.merged && 'Increment version for' || 'Closing' }} PR #${{ github.event.pull_request.number }}" on: # https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ @@ -39,10 +39,12 @@ jobs: # The files that contain source code for the action. Only files that affect the action's execution # should be included like action.yml or package.json. Do not include files like README.md or .gitignore. # Files do not need to be explicitly provided here if they fall under one of the dirs in dirs-with-code. + # The format of this input is a comma-separated string. # ** This value must match the same files-with-code argument specified in build-and-review-pr.yml. files-with-code: 'action.yml,package.json,package-lock.json' # TODO: Update if there are additional files or scripts. # The directories that contain source code for the action. Only dirs with files that affect the action's # execution should be included like src or dist. Do not include dirs like .github or node_modules. + # The format of this input is a comma-separated string. # ** This value must match the same dirs-with-code argument specified in build-and-review-pr.yml. dirs-with-code: 'src,dist' # TODO: Update if there are additional directories with code for the action.