-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 11 support: Currency formats #966
Comments
Hey, can I take this as my first issue? :) |
Hello @mgabor6 👋 I think it's a good first issue. Please go ahead with the check. |
Thanks! I've checked the code base specifically for currency formatting, and there are no usage of it. Although there is possible, that the same could occur at general number or date formatting, because they both depends on Locale, so I've started to dive into Java 11 formatting, and will write some tests for these. |
Ok @mgabor6 let us know how it goes 👍 |
@mgabor6 any news? |
The result of the investigation was that Java currencies are not used in the project. |
Hey @iluwatar . Sorry for the hiatus, I had ongoing projects, and they just ended. From now on I'll have some spare time to dive into Java 11 formatting if needed. |
@mgabor6 no problem. I think there's nothing to investigate in this issue anymore, but please look into other tasks if you find something interesting. https://github.com/iluwatar/java-design-patterns/issues |
Thanks :) |
This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Do we use currency formats that could cause problems, as described in https://winterbe.com/posts/2018/08/29/migrate-maven-projects-to-java-11-jigsaw/? Report findings under this issue.
The text was updated successfully, but these errors were encountered: