Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with JDK 17 #2035

Closed
iluwatar opened this issue Sep 28, 2022 · 6 comments · Fixed by #2331
Closed

Build with JDK 17 #2035

iluwatar opened this issue Sep 28, 2022 · 6 comments · Fixed by #2331

Comments

@iluwatar
Copy link
Owner

This task is part of the transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition. Here we address the issues that come up when building the project with JDK 17 using language level Java 11.

Acceptance criteria

  • Build the project with JDK 17 while keeping the maven-compiler-plugin language level at 11
  • Fix the errors that come up during the build
@harikesh409
Copy link

@iluwatar ,
Can I work on this

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 3, 2022

Yes, go ahead @harikesh409

@tylnesh
Copy link

tylnesh commented Oct 5, 2022

Is this already fixed in master branch? I've built the current state against JDK17 and have no errors.

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 5, 2022

For me, it fails during naked objects integration tests

@robertvolkmann
Copy link
Contributor

@iluwatar Could I work on this?

@iluwatar
Copy link
Owner Author

@harikesh409 I'll assign @robertvolkmann to this issue as well. This is high priority and would like to see it completed soon.

Repository owner moved this from In Progress to Done in Java Design Patterns project Nov 30, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants