Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when computing relavant_docs (qrels) #69

Open
tonywu71 opened this issue Nov 11, 2024 · 0 comments
Open

Bug when computing relavant_docs (qrels) #69

tonywu71 opened this issue Nov 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tonywu71
Copy link
Collaborator

Description

At the following line, the relavant_docs dictionary is overridden instead of getting updated. This causes relavant_docs to only contain the last seen query. This is problematic in datasets with duplicate queries (e.g. DocVQA) as the output score is not correctly computed.

relevant_docs[query] = {queries2filename[query]: 1}

@tonywu71 tonywu71 added the bug Something isn't working label Nov 11, 2024
@tonywu71 tonywu71 self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant