Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint only shows temperature/pressure from rank 0 #258

Closed
majosm opened this issue Feb 22, 2021 · 2 comments
Closed

Checkpoint only shows temperature/pressure from rank 0 #258

majosm opened this issue Feb 22, 2021 · 2 comments

Comments

@majosm
Copy link
Collaborator

majosm commented Feb 22, 2021

While working on #257 today I noticed that the current checkpoint code only uses the temperature and pressure data from rank 0 when writing status information to stdout. This seems potentially misleading. Should it be doing reductions over the whole domain instead?

@MTCam
Copy link
Member

MTCam commented Feb 23, 2021

Correct. The original code which collected field statistics across all ranks was removed in favor of using the discretization's built-in norms. It was my understanding that these norms would be extended on the inside to perform the parallel reductions.

This whole thing may be OBE after #96, as I think that facility may take over responsibility for doing runtime field data stats/reports.

@inducer
Copy link
Contributor

inducer commented Feb 24, 2021

Agree, #96 should take care of that. Since we don't need the same info reported twice, maybe we can make this issue about removing the old code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants