Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging of non-float values #28

Open
matthiasdiener opened this issue Oct 27, 2020 · 3 comments
Open

Allow logging of non-float values #28

matthiasdiener opened this issue Oct 27, 2020 · 3 comments

Comments

@matthiasdiener
Copy link
Member

matthiasdiener commented Oct 27, 2020

Currently, add_quantities() is restricted to floats.

@inducer
Copy link
Collaborator

inducer commented Oct 27, 2020

I'd find it useful to target this to a concrete use case. Which one do you have in mind?

@matthiasdiener
Copy link
Member Author

matthiasdiener commented Oct 27, 2020

My current use case is to log the output of pyinstrument, which can't be easily transformed into floats, but it would be helpful to store it as text.

@inducer
Copy link
Collaborator

inducer commented Oct 28, 2020

I find that that might be using the wrong tool for the job. PyInstrument is used ad-hoc during development, not on an ongoing basis. So it doesn't really need structured data gathering. Plus the output from it is, for all intents and purposes, a big binary blob, where there are only disadvantages if you keep it in a SQL database. You can, but that doesn't mean you should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants