Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Postgres: Connection Parse Error #1865

Open
1 of 3 tasks
pl-ajessop opened this issue Jul 13, 2023 · 2 comments
Open
1 of 3 tasks

Resource Postgres: Connection Parse Error #1865

pl-ajessop opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
Improvement Postgres Postgres related issues

Comments

@pl-ajessop
Copy link

pl-ajessop commented Jul 13, 2023

Description

When I configure a PostgreSQL connection with a hash in the password, I expected the connection to work, but I got a URL parse error instead

Steps to reproduce

  1. Create PostgreSQL username/password with a # in the password
  2. Configure a new PostgreSQL connection in Illa (enter all the details, e.g. hostname, port, database, username, password)
  3. Ensure that the password has a # in it.
  4. Click 'Test Connection' button.
  5. See the error raised.

ILLA Builder Version

latest docker container - could not find a version number in the UI

Browser

Google Chrome 113.0.5672.126

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

When I have a password like 'abc#123' I get the following error:
test connection failed: cannot parse `postgresql://postgres:xxxxxx@temp-dev-iam3-cluster.cluster-xxxx.ap-southeast-2.rds.amazonaws.com:5432/database`: failed to parse as URL (parse "postgresql://postgres:abc": invalid port ":abc" after host)

I suspect the # is being treated as a comment and therefore the host:port section of the URL can't be parsed.

I also tried to escape the # with a backslash '' as a workaround, but this didn't work.

Let me know if you need more info or can't reproduce. Happy to help out where I can.

@pl-ajessop
Copy link
Author

pl-ajessop commented Jul 13, 2023

Update: if I replace the # with %23 (URL escape code) this works. So you're probably missing some URL escaping somewhere. I will continue with the workaround for now 😄

@naj1n
Copy link
Contributor

naj1n commented Jul 13, 2023

Thanks for your issue, we'll optimize for this.

@naj1n naj1n added Postgres Postgres related issues Improvement labels Jul 13, 2023
@AruSeito AruSeito assigned karminski and unassigned naj1n Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Postgres Postgres related issues
Projects
None yet
Development

No branches or pull requests

3 participants