Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default selection #53

Closed

Conversation

mariosh346
Copy link
Contributor

The previous pull request closed

@iliyaZelenko
Copy link
Owner

@mariosh346 Thanks for the PR's, now I will watch them. I seem to have set up a Circle CI, could you create a new test PR? He should run tests.

iliyaZelenko added a commit that referenced this pull request Mar 8, 2019
disable the selection of the first item from the list of items in menu when to press enter (when no
item is selected)

re #53
@iliyaZelenko
Copy link
Owner

iliyaZelenko commented Mar 8, 2019

I did what you asked, but I had to rewrite your code from scratch.

The new prop is called disableFirstItemSelectOnEnter (ef56833).

Today I will release a new version.

iliyaZelenko added a commit that referenced this pull request Mar 8, 2019
disable the selection of the first item from the list of items in menu when to press enter (when no
item is selected)

re #53
iliyaZelenko pushed a commit that referenced this pull request Mar 8, 2019
# [2.7.0](v2.6.1...v2.7.0) (2019-03-08)

### Features

* **items menu:** added scrollToItemIfNeeded with true by default ([cdaa072](cdaa072)), closes [#50](#50)
* **props:** added new prop disableFirstItemSelectOnEnter ([1483b9e](1483b9e)), closes [#53](#53)
iliyaZelenko pushed a commit that referenced this pull request Mar 17, 2019
# [2.8.0](v2.7.0...v2.8.0) (2019-03-17)

### Features

* **items menu:** added scrollToItemIfNeeded with true by default ([aec02ef](aec02ef)), closes [#50](#50)
* **props:** added `input-styles` prop for custom styles on input ([472d176](472d176)), closes [#2](#2)
* **props:** added new prop disableFirstItemSelectOnEnter ([ef56833](ef56833)), closes [#53](#53)
rin4573281133639 added a commit to rin4573281133639/iliyaZelenko9 that referenced this pull request Feb 5, 2022
# [2.7.0](iliyaZelenko/vue-cool-select@v2.6.1...v2.7.0) (2019-03-08)

### Features

* **items menu:** added scrollToItemIfNeeded with true by default ([cdaa072](iliyaZelenko/vue-cool-select@cdaa072)), closes [#50](iliyaZelenko/vue-cool-select#50)
* **props:** added new prop disableFirstItemSelectOnEnter ([1483b9e](iliyaZelenko/vue-cool-select@1483b9e)), closes [#53](iliyaZelenko/vue-cool-select#53)
rin4573281133639 added a commit to rin4573281133639/iliyaZelenko9 that referenced this pull request Feb 5, 2022
# [2.8.0](iliyaZelenko/vue-cool-select@v2.7.0...v2.8.0) (2019-03-17)

### Features

* **items menu:** added scrollToItemIfNeeded with true by default ([aec02ef](iliyaZelenko/vue-cool-select@aec02ef)), closes [#50](iliyaZelenko/vue-cool-select#50)
* **props:** added `input-styles` prop for custom styles on input ([472d176](iliyaZelenko/vue-cool-select@472d176)), closes [#2](iliyaZelenko/vue-cool-select#2)
* **props:** added new prop disableFirstItemSelectOnEnter ([ef56833](iliyaZelenko/vue-cool-select@ef56833)), closes [#53](iliyaZelenko/vue-cool-select#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants