Fix for Scroll to selected item through arrows #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariosh346
force-pushed
the
arrows_scroll_to_selected
branch
from
b90d565
to
b030eea
Compare
mariosh346
changed the title
mariosh346
changed the title
mariosh346
force-pushed
the
arrows_scroll_to_selected
branch
3 times, most recently
from
cea8c12
to
c80bfb5
Compare
Add itemsLimit prop Fix lint error "You should not mix 'v-for' with 'v-if'"
mariosh346
force-pushed
the
arrows_scroll_to_selected
branch
from
c80bfb5
to
47d1039
Compare
|
I'll look at it after sleep, thanks for contributing. I will try to make it come out in the next version soon. |
iliyaZelenko
added a commit
that referenced
this pull request
Mar 8, 2019
to scroll to an item if it has moved beyond the scroll bar re #50
|
Thanks for the PR, but it violates the ESlint rules and scrolling through the I made the scrolling pretty smart, I added |
iliyaZelenko
added a commit
that referenced
this pull request
Mar 8, 2019
to scroll to an item if it has moved beyond the scroll bar re #50
iliyaZelenko
pushed a commit
that referenced
this pull request
Mar 8, 2019
iliyaZelenko
pushed a commit
that referenced
this pull request
Mar 17, 2019
# [2.8.0](v2.7.0...v2.8.0) (2019-03-17) ### Features * **items menu:** added scrollToItemIfNeeded with true by default ([aec02ef](aec02ef)), closes [#50](#50) * **props:** added `input-styles` prop for custom styles on input ([472d176](472d176)), closes [#2](#2) * **props:** added new prop disableFirstItemSelectOnEnter ([ef56833](ef56833)), closes [#53](#53)
rin4573281133639
added a commit
to rin4573281133639/iliyaZelenko9
that referenced
this pull request
Feb 5, 2022
# [2.7.0](iliyaZelenko/vue-cool-select@v2.6.1...v2.7.0) (2019-03-08) ### Features * **items menu:** added scrollToItemIfNeeded with true by default ([cdaa072](iliyaZelenko/vue-cool-select@cdaa072)), closes [#50](iliyaZelenko/vue-cool-select#50) * **props:** added new prop disableFirstItemSelectOnEnter ([1483b9e](iliyaZelenko/vue-cool-select@1483b9e)), closes [#53](iliyaZelenko/vue-cool-select#53)
rin4573281133639
added a commit
to rin4573281133639/iliyaZelenko9
that referenced
this pull request
Feb 5, 2022
# [2.8.0](iliyaZelenko/vue-cool-select@v2.7.0...v2.8.0) (2019-03-17) ### Features * **items menu:** added scrollToItemIfNeeded with true by default ([aec02ef](iliyaZelenko/vue-cool-select@aec02ef)), closes [#50](iliyaZelenko/vue-cool-select#50) * **props:** added `input-styles` prop for custom styles on input ([472d176](iliyaZelenko/vue-cool-select@472d176)), closes [#2](iliyaZelenko/vue-cool-select#2) * **props:** added new prop disableFirstItemSelectOnEnter ([ef56833](iliyaZelenko/vue-cool-select@ef56833)), closes [#53](iliyaZelenko/vue-cool-select#53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus on selectedItemByArrows
Add itemsLimit prop
Fix lint error "You should not mix 'v-for' with 'v-if'"
Issue #39