Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suport .exp() for Ratio #290

Closed
jacg opened this issue Mar 23, 2022 · 3 comments · Fixed by #291
Closed

Suport .exp() for Ratio #290

jacg opened this issue Mar 23, 2022 · 3 comments · Fixed by #291

Comments

@jacg
Copy link
Contributor

jacg commented Mar 23, 2022

Is there any reason not to support .exp() for Ratio?

If not, I'd be happy to submit a PR.
@iliekturtles
Copy link
Owner

See #11. Looks like I punted on implementing exp way back when. A PR to add exp for Ratio would be welcome. Check out some of the inverse trig functions like acos for similar Ratio-only functions. I believe exp will also be std only.

@jacg
Copy link
Contributor Author

jacg commented Mar 23, 2022

Presumably exp2, ln, log etc. are missing for the same reason, and could be added in the same PR?

jacg added a commit to jacg/uom that referenced this issue Mar 23, 2022
@jacg
Implement and test exp for Ratio
8b371ff 
Close iliekturtles#290
@jacg jacg mentioned this issue Mar 23, 2022
Merged
@iliekturtles
Copy link
Owner

iliekturtles commented Mar 24, 2022 •
edited
Loading

Presumably exp2, ln, log etc. are missing for the same reason, and could be added in the same PR?

Yep. Go ahead and add to the PR if that works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement and test exp for Ratio jacg/uom
2 participants
@jacg @iliekturtles