Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molar heat capacity. #263

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Molar heat capacity. #263

merged 1 commit into from
Aug 9, 2021

Conversation

iliekturtles
Copy link
Owner

Initial work to setup the quantity. Still need to add additional units and tests.

@nakedible Any specific units you're looking for? If you could review I would greatly appreciate it.

@iliekturtles iliekturtles force-pushed the dev-molar-heat-capacity branch 2 times, most recently from ad76946 to eea7bd8 Compare August 5, 2021 01:28
@codecov-commenter
Copy link

Codecov Report

Merging #263 (eea7bd8) into master (a7a4ccf) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   96.72%   96.76%   +0.03%     
==========================================
  Files          57       58       +1     
  Lines        2691     2723      +32     
==========================================
+ Hits         2603     2635      +32     
  Misses         88       88              
Impacted Files Coverage Δ
src/si/mod.rs 100.00% <ø> (ø)
src/si/molar_heat_capacity.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a4ccf...eea7bd8. Read the comment docs.

@iliekturtles iliekturtles force-pushed the dev-molar-heat-capacity branch from eea7bd8 to 4c802e6 Compare August 6, 2021 01:05
@iliekturtles iliekturtles force-pushed the dev-molar-heat-capacity branch from 4c802e6 to ed8c1e2 Compare August 9, 2021 12:26
@iliekturtles
Copy link
Owner Author

Build failures are limited to 1.37 (to be fixed in another PR) and there are no other unit suggestions so I'm going to merge!

@iliekturtles iliekturtles merged commit c1194cf into master Aug 9, 2021
@iliekturtles iliekturtles deleted the dev-molar-heat-capacity branch August 15, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants