Add Jerk, L^1 * T^-3 #128
Add Jerk, L^1 * T^-3 #128
Conversation
|
If approved, could you cut a minor or patch release that I may pin in my project? Thanks kindly! |
There was a problem hiding this comment.
Couple more minor changes requested.
I'd also like to see the commits organized / squashed. Ran out of time right now, but will follow up with details.
I'll plan to do a new release once these are merged. I'm hoping to include Angle and Torque at the same time, but I need some more in depth review that may delay them and I'll release this alone.
src/si/mod.rs
Outdated
| @@ -35,6 +35,7 @@ system! { | |||
| energy::Energy, | |||
| force::Force, | |||
| frequency::Frequency, | |||
| jerk::Jerk, | |||
There was a problem hiding this comment.
Move down below inductance::Inductance.
| fn test<L: l::Conversion<V>, T: t::Conversion<V>, J: j::Conversion<V>>() { | ||
| Test::assert_eq( | ||
| &Jerk::new::<J>(V::one()), | ||
| &(Length::new::<L>(V::one()) / |
There was a problem hiding this comment.
Start next line with / operator. Do the same for the * operators. Tab in the contents of the inner-most ()s where the time^3 factor is calculated.
fn test<L: l::Conversion<V>, T: t::Conversion<V>, J: j::Conversion<V>>() {
Test::assert_eq(
&Jerk::new::<J>(V::one()),
&(Length::new::<L>(V::one())
/ (Time::new::<T>(V::one())
* Time::new::<T>(V::one())
* Time::new::<T>(V::one()))));
}
|
Thanks again for the PR! There are a couple minor changes I'm going to include in another commit shortly rather than have you do it. My plan is do some more review of the |
|
v0.22.2 released! |
Useful for robotics and motion planning.
Also added some common CNC units to velocity and acceleration.