Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Momentum #114

Closed
dunmatt opened this issue Mar 21, 2019 · 4 comments
Closed

Building Momentum #114

dunmatt opened this issue Mar 21, 2019 · 4 comments

Comments

@dunmatt
Copy link

dunmatt commented Mar 21, 2019

Would you be open to a PR that adds Momentum (kg*m/s) to uom? If not, is there a recommended way of dealing with momentum?

Edit: same questions for Torque (Nm)

@iliekturtles
Copy link
Owner

I'd love PRs for momentum and torque. Let me know if you need any guidance to get started. NIST 811 appendix B9 has a number of units for torque. Momentum isn't listed so I suggest adding combinations of the most common si prefixes along with common non-si units (e.g. slug ft/s). Also see https://github.com/iliekturtles/uom/blob/master/src/si/mass_rate.rs for some good test examples.

@dunmatt
Copy link
Author

dunmatt commented Mar 21, 2019

Is torque going to run into a problem since it has the same base units as energy?

@iliekturtles
Copy link
Owner

Nope! Specify a new Kind for torque. See temperature interval and thermodynamic temperature for an example how to do this. I haven't done any research to see what a good kind name is. Perhaps just Torque. The new kind will likely want to implement all of the marker traits.

@dunmatt
Copy link
Author

dunmatt commented Mar 21, 2019

Oooh, I've never used a Kind before (although I have vague memories of being taught about them in grad school)... exciting!

dunmatt pushed a commit to dunmatt/uom that referenced this issue Mar 24, 2019
@dunmatt dunmatt mentioned this issue Mar 24, 2019
dunmatt pushed a commit to dunmatt/uom that referenced this issue May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants