-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests fail #1
Comments
Hi, edit: removed cited text for readability |
What I see from the logs of the other two tests (test_wrapper_BFS_adv edit: removed cited text for readability |
OK, that makes sense. I upgraded to scikit-learn 0.17.1. Is there an automated way to generate the new "expected" results and update the test suite? |
There is no automated way but you should be able to run the code from /import sys//
//import utils//
//import numpy as np//
//import ilastik_feature_selection//
//import sklearn//
//import unittest//
//import os//
//import logging//
//
//rf = sklearn.ensemble.RandomForestClassifier(random_state = 14271,
n_estimators = 10)//
//X = np.load(os.path.dirname(os.path.realpath(**file**))
+"/digits_data.npy")//
//Y = np.load(os.path.dirname(os.path.realpath(**file**))
+"/digits_target.npy")//
//
//eval_fct =
ilastik_feature_selection.wrapper_feature_selection.EvaluationFunction(rf,
complexity_penalty=0.4)//
//feat_selector =
ilastik_feature_selection.wrapper_feature_selection.WrapperFeatureSelection(X,
Y, eval_fct.evaluate_feature_set_size_penalty, method="BFS")//
//a = feat_selector.run(do_advanced_search=False)/ (make sure that the path to the .npy arrays is correct. You can find the The test expects: /self.assertEqual(a[1], 1.1995)//
//self.assertEqual(set(a[0]), set([10, 13, 20, 29, 35, 37, 42, 44, 51,
53]))/ These are the lines that need to be updated. Cheers, Fabian edit: removed cited text for readability, added code formatting |
So, I'm really unhappy with these tests, they take ages. Also it seems that @FabianIsensee suggests to update the tests by regenerating the results with the test-code? How can we then, be ever sure, that nothing has significantly changed? Right now the differences are striking! |
Apparently the unit tests in this repo used to pass, but now I'm seeing failures. Are we concerned about that?
Here's the test log I get. (The tests take a really long time to run, so I stopped them early, hence the
^C
from when I hitCtrl+C
.)ping: @akreshuk @FabianIsensee
The text was updated successfully, but these errors were encountered: