Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in data loader? #14

Open
ChenyunWu opened this issue Oct 2, 2020 · 3 comments
Open

Bug in data loader? #14

ChenyunWu opened this issue Oct 2, 2020 · 3 comments

Comments

@ChenyunWu
Copy link

In CMIN_moment_retrieval/dataloaders/clip_loader.py line 66
if label[1] == video.shape[0] - 1:
Shouldn't it be:
if label[1] == ori_video_len:?
Since you changed the video and its length is now always self.max_num_frames

@onlyonewater
Copy link

I think the logic of this code feels strange!!!

@ikuinen
Copy link
Owner

ikuinen commented Nov 22, 2020

In CMIN_moment_retrieval/dataloaders/clip_loader.py line 66
if label[1] == video.shape[0] - 1:
Shouldn't it be:
if label[1] == ori_video_len:?
Since you changed the video and its length is now always self.max_num_frames

Thanks for reminding. We have corrected this in the subsequent use but have not updated this code. Even with a low probability, this may cause an error when length > self.max_num_frames and label[1] == self.max_num_frames - 1.

@Starboy-at-earth
Copy link

Dear ChenyunWu:

Could you please tell me how to process the splitted C3D features of Activity Caption dataset? It is weired five parts and I cannot figure out how to restore such files with suffixs of .part-XX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants