Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adventure map, castle info window, the castle information window should be displayed if a part of the castle is visible #2156

Closed
LeHerosInconnu opened this issue Nov 1, 2020 · 5 comments
Labels
bug Something doesn't work good first issue Good for newcomers ui UI/GUI related stuff
Milestone

Comments

@LeHerosInconnu
Copy link

In the original game, it is possible to display the castle information window if a part of the castle has been revealed.
In fheroes2, this does not work the same way.

In original game:

Castle info window H2 01

Castle info window H2 02

In fheroes2:

Castle info window fh2 01

Castle info window fh2 02

@Branikolog Branikolog added the question Question asked label Nov 1, 2020
@Branikolog
Copy link
Collaborator

Hello, @LeHerosInconnu !
On the screenshots revealed parts of castle are different.
Are you sure, that issue is actual within the same conditions?

@LeHerosInconnu
Copy link
Author

Hi @Branikolog,

Hello, @LeHerosInconnu !
On the screenshots revealed parts of castle are different.
Are you sure, that issue is actual within the same conditions?

Even if a larger part of the castle is revealed, it doesn't work like in the original game either.

In fheroes2:

Castle info window fh2 03

Here is the save file:
Castle info 01.zip

@Branikolog
Copy link
Collaborator

Yes, original behaviour is not obvious:
While right click on a squares behind a castle we can see a castle info. While in fheroes2 we can see castle's statistics only over the cells, where a castle is located.

@Branikolog Branikolog added bug Something doesn't work good first issue Good for newcomers ui UI/GUI related stuff and removed question Question asked labels Nov 7, 2020
@Branikolog Branikolog added this to the 1.0 milestone Nov 7, 2020
@LeHerosInconnu
Copy link
Author

Hello @Branikolog,

Yes, original behaviour is not obvious:
While right click on a squares behind a castle we can see a castle info. While in fheroes2 we can see castle's statistics only over the cells, where a castle is located.

In the original game, all the squares where part of the castle/town sprite is located (except the squares of the castle shadow) allow the player to display the castle/town information window with a right click.

In the editor, these squares are brown for the bottom of the castle/town sprite, the square at the entrance of the castle/town is orange, and the squares at the top of the castle/town sprite are green.
During the game, all these squares (brown, orange and green) can be used to display the information window of the castle/town with a right click.

In the editor, the black squares represent the shadow of the castle/town.
During the game, these squares (black) cannot be used to display the castle/town information window with a right click.

In original game:

Castle info right 01

Castle info right 02

Castle info right 03

@ihhub
Copy link
Owner

ihhub commented Aug 1, 2021

The issue was fixed some time ago.

@ihhub ihhub closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work good first issue Good for newcomers ui UI/GUI related stuff
Projects
None yet
Development

No branches or pull requests

3 participants