Fast split logic global discussion

[Branikolog]

Here it is!
It's time to discuss the way we want to split creatures in different scenarios using keyboard and mouse.

[Branikolog]

First of all I want to thank our team and contributors, who help with finding and implementing the best solutions for this nice project!

[Branikolog]

I think, we should add always [2] button to any split dialog.

@LeHerosInconnu pushed a good idea: if we're splitting creature, change some values in dialog window, but changed our mind and want to split it into two separate equal stacks again (not 3, 4 or 5) we have to manually set the quantity of transferred creatures.
[on a screenshot we're trying to split 100 vampires. We manually set 15, but changed our mind and want to split them equally into two stacks. [2] button would help to recover the quantity without counting or re-making the dialog]
From my point I heavily insist on leaving the default separation of stack over empty slot in two equal sizes (So on default [2] button should always glare being selected), as this situation is the most common. I mean when we divide stack into two equal. In this case creature counter should display the quantity of creatures transferred equal to a half of original stack.

If we are going to split one stack of creatures over an other existing stack of creatures of the same type, within single army, the default transferring quantity should be 1 (minimal) as it shows how many creatures we want to add to target stack. (@LeHerosInconnu noted before, that this would help player to understand, that he is adding a certain amount of creatures to the target stack. My addition is to set the default not "0" (@LeHerosInconnu's proposal) but at least "1", so we can perform any action on pressing OK button from the default dialog state. If we want to transfer "0" creatures we can simply cancel the dialog. :D )

In this case we should anyway have at least [2] button to be able to equalize both stacks and also (if possible) in 3, 4 or 5. In case of pressing 3, we should as a result have 3 equal stacks of creatures (counting the basic one, the target one and new one created in free slot.


This behaviour should be the same for splitting into 4 or 5 stacks. In the example above we should be able to divide creatures into 5 stack as well.

In a case of splitting one stack over an empty slot, while there's another stack of the same type in current army, we shouldn't consider that another stack and split the target stack into 2, 3 or 4 regarding overall free slots in current army. Which is the case currently.
If we want to create multiple equal stacks of the same type we first need to unite them. (except the case we're splitting over an other existing stack, which I reviewed above) (in a case we have only two stacks of the the same type)

Not to loose the functionality of this dialog window for the case, while transferring between two armies or between hero army and town garrison, I propose to leave all [2], [3] [etc.] buttons and allow player to split selected stack into several, leaving the first stack at the same place, and placing the rest into meeting hero/town garrison armies. The splitting into two stacks works currently as I mentioned before (Only [2] button is not implemented yet).



In a case of splitting the basic stack into 3, 4, 5 or 6(new value) we should operate the same: select stack, select garrison army (or meeting hero) and press [3], [4], [5] or [6] button to make equal stacks leaving one in its basic position:

In the example above we should be able to split basic stack into 6 stacks: one + 5 in garrison.

If we're going to transfer the basic stack in hero's army over an existing stack of the same type of garrison army we should also operate the same, as I've explained above:
The default transferring quantity should be "1".

While pressing [2], [3], [4] etc. fast split buttons we should create needed amount of equal stacks leaving one in our basic stack's position:



[6] should also be available in this case.

[LeHerosInconnu]

@Branikolog.

Nice post. :)
Everything seems good so far.
All that remains is to implement and test it. :)

[Branikolog]

@LeHerosInconnu
Do you have any additions/objections or did I missed something?

[LeHerosInconnu]

@Branikolog.

@LeHerosInconnu
Do you have any additions/objections or did I missed something?

No, if I understood everything correctly, it should work. :)

[Branikolog]

Also, I remember a brilliant suggestion of @LeHerosInconnu regarding changing of display quantity in creature counter, while pressing [2], [3], [4] or [5] fast split buttons, which would show the result stack size while splitting into several equal. Do we have an opened issue for that?

[Branikolog]

Oh, nice!
I have a small improvement for this issue:
In a case of pressing any fast split button I propose to change the title of the window "How many troops to move?" so it corresponds the action we're choosing: "Create X groups of troops". (As usual, I ask for help with text description, because of my poor english)
So below the new description we would see the size of each stack inside of a troop counter, which should be updated, while choosing different fast split buttons.
In a case we start pressing arrows to change the amount of transferred troops, or using scroll wheel we should cancel fast split button selection and return original title in the upper part of window back.

[LeHerosInconnu]

@Branikolog.

Oh, nice!
I have a small improvement for this issue:
In a case of pressing any fast split button I propose to change the title of the window "How many troops to move?" so it corresponds the action we're choosing: "Create X groups of troops". (As usual, I ask for help with text description, because of my poor english)
So below the new description we would see the size of each stack inside of a troop counter, which should be updated, while choosing different fast split buttons.
In a case we start pressing arrows to change the amount of transferred troops, or using scroll wheel we should cancel fast split button selection and return original title in the upper part of window back.

Good idea too. :)

Something like this:

"Divide the troop into X troops."
"Divide the troop into X groups."

"Separate the troop into X troops."

"Split the troop into X troops."

"Distribute the troop into X troops."

The word "groups" can be used to avoid repeating the word "troops", but using the word "troops" twice doesn't shock me.

I would prefer:

"Split the troop into X troops."

Or:

"Divide the troop into X troops."

[Branikolog]

Sounds good.
Is it possible to add phrase to a sentence, where the last word inteded to be the number of creatures in each stack? So the counter below will be the part of the whole sentence.
Something like: " ... with a stack size of: "
And it should be short enough to fit into single line...
Could you, please, advise something?
If we don't have anough place for that, I like all the variations above.

[LeHerosInconnu]

@Branikolog.

Sounds good.
Is it possible to add phrase to a sentence, where the last word inteded to be the number of creatures in each stack? So the counter below will be the part of the whole sentence.
Something like: " ... with a stack size of: "
And it should be short enough to fit into single line...
Could you, please, advise something?
If we don't have anough place for that, I like all the variations above.

This seems difficult without changing the width of the window. :D

The sentence "Split the troop into X troops." may already be too long.

But the reduced sentence "Split into X troops of:" should be short enough. :)

[Branikolog]

"Split into X troops of:"

That looks quite short and informative for me!