Explicitly link the shell32. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For details, please see rust-lang/rust@81de5d9
|
Thanks for the pull request! |
|
Thank you for merging my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to link explicitly because std crate no longer depends on the shell32.
This change of std crate does affect, currently the nightly only.
For details, please see rust-lang/rust@81de5d9
I'm sorry. I forgot to write the reason for this change.
PDCurses Win32a uses shell32 's ExtractIconW function, but because std crate no longer links shell32, pdcurses- sys crate fails to link programs that use the win32a feature and use it.