-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL doesn't work after setting TCPSocket = EventMachine::Synchrony::TCPSocket #82
Comments
Unfortunately that's not surprising. Existing TCPSocket functionality is very basic, as in it only implements a few methods of the API. The SSL stuff specifically shouldn't be hard to add, but yeah.. I wouldn't even call it a bug, but rather a feature request. (I should document that TCPSocket class more to be explicit about the minimal functionality) |
I dug into the Ruby C code and it looks like it's failing in SSLSocket because the passed socket isn't a File, i.e. "Check_Type(io, T_FILE)". I don't know how it can work with the original TCPSocket class (which is also not a File). For whatever it's worth, it doesn't look like EM::TCPSocket is missing anything, it's just that SSL is unreasonably picky about the socket type. |
Well, I don't think we would want to try to wrap that, we need to use the built-in EM SSL primitives.. which is actually as simple as |
Is this still on the radar of getting worked on or just sitting in the backlog for now? Would really like this to be implemented. Thanks! |
It's definitely on the backlog, and to be honest.. unlikely to be resolved. I don't think we'll be able to match the SSL API's. |
Is it because there is no time for this or just technical impossible? From the comments it sounded like it's doable. |
EM's SSL layer and net/http SSL layer are two entirely different beasts.. Perhaps it come be made to work, but I'm not too hopeful. I have a strong feeling that even if we do get the basic case to work, we'll end up running into all kinds of edge cases. |
minimum to reproduce:
triggers:
The text was updated successfully, but these errors were encountered: