-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate, then remove mode="total" #914
Comments
Many functions which are not auto-generated already do not use |
This is very low priority. Given the workload we have, I would put this off indefinitely. I suggest not to spend time on it now @maelle. |
Low priority, but it wouldn't be hard to put this into the lifecycle system, so please ping me again if you change your mind @szhorvat |
Given how constrained we are for resources, I suggest dropping this task. "total", as a descriptor, is a perfect fit for Doing this would in the end be quite a bit of work for just an aesthetic improvements. I think we have higher priorities, such as exposing new functionality ... |
The "neighbour mode"
mode
parameter (igraph_neimode_t
in C) can take values"out"
,"in"
,"all"
and"total"
. However,"total"
is just an alias for"all"
, and in my opinion in most contexts it is not a fitting name. The naming perhaps makes sense for degrees, but not for situation where it described in which direction to follow edges.The same name has already been removed from the C core.
Can we start a deprecation process for R as well? Is there a clean deprecation route that is compatible with the auto-generation we are using, @maelle ?
@krlmlr At some point can you remove
"total"
from auto-generation and run revdepchecks, to see who is using it?The text was updated successfully, but these errors were encountered: