Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ransack 4.0 has breaking change #131

Closed
ykamin-booth opened this issue Feb 10, 2023 · 2 comments
Closed

Ransack 4.0 has breaking change #131

ykamin-booth opened this issue Feb 10, 2023 · 2 comments

Comments

@ykamin-booth
Copy link

FYI, this PR which just got pulled into Ransack 4.0 has a breaking change for rails_db, requiring an explicit allowlist for every attribute that it's allowed to search over. I reverted my ransack version for now but it's worth thinking about how to handle this.
@igorkasyanchuk
Copy link
Owner

@ykamin-booth can you make a PR and just allow all attributes?

@le-murier le-murier mentioned this issue May 3, 2023
Merged
@igorkasyanchuk
Copy link
Owner

should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igorkasyanchuk @ykamin-booth