Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATE: Change Module Discovery to Find Proto Files in cosmossdk.io Packages #3841

Open
jeronimoalbi opened this issue Dec 15, 2023 · 1 comment
Open

UPDATE: Change Module Discovery to Find Proto Files in cosmossdk.io Packages #3841

jeronimoalbi opened this issue Dec 15, 2023 · 1 comment
Labels
component:go Related to core go code. type:refactor
Milestone
v29

Comments

@jeronimoalbi
Copy link
Member

jeronimoalbi commented Dec 15, 2023 •
edited
Loading

Module proto files can currently be found in cosmos-sdk proto directory but those files are going to be moved into each individual module, see cosmos/cosmos-sdk#12003.

This change will break module discovery for cosmossdk.io module packages when we update Ignite CLI's cosmos-sdk dependency to v0.51 or eventual release that contains the changes with the new proto file location.

Module discovery will be simplified with this change.
@jeronimoalbi jeronimoalbi added type:refactor component:go Related to core go code. labels Dec 15, 2023
@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Dec 15, 2023 •
edited
Loading

@julienrbrt thanks for the updates regarding the cosmos-sdk change 👍

@salmad3 salmad3 added this to the v29 milestone May 29, 2024
@salmad3 salmad3 changed the title Change module discovery to find proto files in cosmossdk.io packages UPDATE: Change Module Discovery to Find Proto Files in cosmossdk.io Packages Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:go Related to core go code. type:refactor
Projects
Ignite CLI Masterboard
Status: Todo
Milestone
v29
Development

No branches or pull requests
2 participants
@jeronimoalbi @salmad3