Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Support Param Change requests #2899

Closed
2 tasks done
Tracked by #3115
lumtis opened this issue Oct 7, 2022 · 3 comments · Fixed by #3142
Closed
2 tasks done
Tracked by #3115

Network: Support Param Change requests #2899

lumtis opened this issue Oct 7, 2022 · 3 comments · Fixed by #3142
Assignees
@aljo242
Labels
component:network
Milestone
v0.26.0

Comments

@lumtis
Copy link
Contributor

lumtis commented Oct 7, 2022 •
edited by aljo242
Loading

  • Support modifying the genesis module params by the list of param changes in the launch information during the genesis generation process of prepare
  • Add a command to request a param change
ignite n request param [module-name] [param-name] [value (json, string, number)]
@lumtis lumtis added this to the T1 milestone Oct 7, 2022
@lumtis lumtis mentioned this issue Oct 20, 2022
Open
13 tasks
@aljo242 aljo242 self-assigned this Oct 26, 2022
@lumtis lumtis mentioned this issue Nov 15, 2022
Open
11 tasks
@aljo242 aljo242 mentioned this issue Nov 21, 2022
Merged
@lumtis
Copy link
Contributor Author

lumtis commented Nov 24, 2022

@aljo242 can you confirm this part is not yet implemented?

Support modifying the genesis module params by the list of param changes in the launch information during the genesis generation process of prepare

@aljo242 aljo242 mentioned this issue Dec 1, 2022
Merged
@aljo242
Copy link
Contributor

aljo242 commented Dec 1, 2022

@aljo242 can you confirm this part is not yet implemented?

Support modifying the genesis module params by the list of param changes in the launch information during the genesis generation process of prepare

Correct, #3208 adds the functionality.

@aljo242
Copy link
Contributor

aljo242 commented Dec 8, 2022

#3208 merged

@aljo242 aljo242 closed this as completed Dec 8, 2022
@aljo242 aljo242 modified the milestones: T1, v0.26.0 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aljo242 aljo242

Labels
component:network
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging a pull request may close this issue.

feat(network): param-change ignite/cli
2 participants
@lumtis @aljo242