Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodetime: drop ts to js compilation #1310

Closed
ilgooz opened this issue Jun 29, 2021 · 3 comments
Closed

nodetime: drop ts to js compilation #1310

ilgooz opened this issue Jun 29, 2021 · 3 comments
Assignees

Comments

@ilgooz
Copy link
Member

ilgooz commented Jun 29, 2021

To make scaffold commands faster and also to be able to use the new version of pkg so we can create ARM binaries for nodetime.

Also helpful for #1285.

@ilgooz ilgooz self-assigned this Jun 29, 2021
@faddat
Copy link
Contributor

faddat commented Jun 29, 2021

do that later, like after the user has scaffolded the chain?

@ilgooz
Copy link
Member Author

ilgooz commented Jun 30, 2021

closing this because tsc is not the bottleneck on speed. also, we need it anyway to type check the generated ts libs.

@ilgooz ilgooz closed this as completed Jun 30, 2021
@faddat
Copy link
Contributor

faddat commented Jul 1, 2021

hm. I think I get what you're getting at here, please disregard my comments about merging the feat/linux-arm64 I found the issue there.

Since I'm trying to get https://gitub.com/babyblockchains/lotus launched on a swarm of Pies, I may implement this issue anyhow and let you know.

The other thing is that this really shouldn't be causing the kinds of problems that it clearly is. I remain puzzled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants