Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation deletion on null assignment. #6

Open
lesf0 opened this issue Feb 17, 2017 · 1 comment
Open

Translation deletion on null assignment. #6

lesf0 opened this issue Feb 17, 2017 · 1 comment

Comments

@lesf0
Copy link

lesf0 commented Feb 17, 2017

Hello!

I don't understand well why the "value" field should be nullable. I think it would be better if assignment of null/empty value mean deleting of this particular translation.

I currently building an multilingual site, in which admin has ability to enter texts in different languages. If the text for some language wasn't filled by site admin, or was cleared, it obviously means "Translation is not available yet, English text should be used instead", not "Nothing should be displayed in this language". For now I have to handle it in controller, but I think this should be done by translation trait itself.

@lesf0 lesf0 changed the title Transition deletion on null assignment. Translation deletion on null assignment. Feb 17, 2017
@ronappleton
Copy link

I think this is a valid point, we should fallback to the default language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants