Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve standard button theme for dark mode #1111

Open
dfabulich opened this issue Nov 10, 2024 · 0 comments
Open

Improve standard button theme for dark mode #1111

dfabulich opened this issue Nov 10, 2024 · 0 comments
Labels
dark mode needs discussion It's not clear how to begin/finish this visual design Improve how IFDB looks

Comments

@dfabulich
Copy link
Collaborator

We have a fancy-button class that we use for some buttons on the site, but many buttons are just plain old HTML buttons.

That's fine, but those buttons don't theme themselves in dark mode. But, what color should they be? They need to be prominent enough to notice against a black background. 🤔

Even the fancy-button doesn't have a dark variant. (We didn't inherit any suggestions from MJR's Midnight theme.) It's easy to style now, so we should probably do that, too.

@dfabulich dfabulich added needs discussion It's not clear how to begin/finish this visual design Improve how IFDB looks dark mode labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dark mode needs discussion It's not clear how to begin/finish this visual design Improve how IFDB looks
Projects
None yet
Development

No branches or pull requests

1 participant