Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh look of file format / external link icons #1088

Open
salty-horse opened this issue Nov 9, 2024 · 2 comments
Open

Refresh look of file format / external link icons #1088

salty-horse opened this issue Nov 9, 2024 · 2 comments

Comments

@salty-horse
Copy link
Collaborator

salty-horse commented Nov 9, 2024

The file format icons in the external links feel extremely ancient.

I think it's no longer appropriate to represent a web-hosted game with an icon for "HTML file".

There are also missing icons for things like images, and it would be nice to fill those gaps. Maybe even have dedicated icons for storefronts like Steam and itch.io.

Discussion: https://intfiction.org/t/refresh-look-of-file-format-external-link-icons/72269

@salty-horse
Copy link
Collaborator Author

Easy replacement Glulx icon:
Old: old
New: glulx-logo

@salty-horse
Copy link
Collaborator Author

This is how to edit a file icon:
http://localhost:8080/fileformat?id=25&edit

Some problems:

  • Only GIFs are supported.

  • Identical images are not reused between formats, and are stored separately.

  • Images are returned without caching, even though they are used in many places.

  • This comment doesn't make sense:

    This icon is used as a fallback if the. File Type doesn't have an associated icon.

    These are the file type icons. In viewgame, the only thing that is checked before it is the "OS icon".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant