Inclomplete Configuration Examples and Missing Documentation

[YBachmann]

I noticed some discrepancies in the provided configuration files.

The file /config/ods_default_parameters.yaml includes a line config_file: "config/examples/o3r_ods.json" but config/examples/o3r_ods.json does not exist in the repository.

The other yaml files in the config folder (o3r_2d.yaml, o3r_3d.yaml, two_o3r_heads.yaml and camera_default_parameters.yaml) do not include the config_file parameter at all.

This confused me at first because there is no direct hint or documentation that the yaml configuration files need a reference to another json configuration file.

Also by not providing a default configuration file users will get inconsistent behaviour when running the same launch command multiple times because not a fixed default configuration will be loaded but rather the last-saved settings from the VPU (which can get modified in different places like the vision assistant).

Proposed changes:

• add the config_file parameter in all yaml configuration files (e.g. config_file: "config/examples/o3r_port_settings.json")
• create default json configuration files (e.g. config/examples/o3r_port_settings.json and config/examples/o3r_ods.json)
• explain in the documentation that there are two kind of configuration files. For the nodes and their ros specific parameters there are yaml files. For the o3r specific parameters, there are json files that get referenced in the yaml files.

What do you think of this? I can happily create a PR to implement the proposed changes.

[lola-masson]

Hi @YBachmann,

Thanks a lot for the suggestion! We would happily review a PR with these changes.

One thing to keep in mind, is that there will be a "duplicate" of port info, in the yaml (pcic_port), and in the json (/ports/portX). So this should be clear in the documentation: if you accidentally provide a json file with a port number that differs from the one in the yaml, then the configuration will be done "for nothing", if that makes sense.