New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoization of `all` may cause issues #50

Open

tagliala opened this issue Jan 22, 2024 · 0 comments

Labels

Member

tagliala commented Jan 22, 2024

hawk/lib/hawk/model/proxy.rb

Lines 40 to 42 in d348cb5

    
           def all(params = {}) 
        
             @result ||= klass.all(@params.deep_merge(params)) 
        
           end

This is not taking into consideration the fact that there could be different parameters.

Probably memoization here is wrong

tagliala added the need triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment