Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming docker directory #3467

Closed
ietf-svn-bot opened this issue Nov 11, 2021 · 2 comments
Closed

Consider renaming docker directory #3467

ietf-svn-bot opened this issue Nov 11, 2021 · 2 comments

Comments

@ietf-svn-bot
Copy link

type_defect | by [email protected]


Now that we're moving to docker-compose, we need to consider changing the docker directory name.

See docker/compose#745

By convention, docker-compose is creating containers and networks named after the directory, hence docker<whatever> which is likely to cause confusion at best, and collision at worst.

We could carefully supply an alternate project name with -p everywhere that the docker-compose command line tool is used, but that is hard to maintain, and a volunteer may forget it when running the command manually, creating local damage that will take that developer time to straighten out.

We could use the environment variable, but that needs to be set on the host - easy to do with scripts (but with the same maintenance problem), but individual volunteers would need to remember to do this in their host shell or the above bad things could happen to them.

So, we should consider renaming the /docker directory to something like /dt-docker or /docker-dt or maybe /dtdev. (Good bikeshed to talk about here.) Several files under /docker would have to be updated to reflect the result.


Issue migrated from trac:3467 at 2022-03-04 09:20:03 +0000

@ietf-svn-bot
Copy link
Author

@[email protected] changed status from new to under_review

@rjsparks
Copy link
Member

OBE - docker-compose was moved to the root directory

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants