You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By convention, docker-compose is creating containers and networks named after the directory, hence docker<whatever> which is likely to cause confusion at best, and collision at worst.
We could carefully supply an alternate project name with -p everywhere that the docker-compose command line tool is used, but that is hard to maintain, and a volunteer may forget it when running the command manually, creating local damage that will take that developer time to straighten out.
We could use the environment variable, but that needs to be set on the host - easy to do with scripts (but with the same maintenance problem), but individual volunteers would need to remember to do this in their host shell or the above bad things could happen to them.
So, we should consider renaming the /docker directory to something like /dt-docker or /docker-dt or maybe /dtdev. (Good bikeshed to talk about here.) Several files under /docker would have to be updated to reflect the result.
Issue migrated from trac:3467 at 2022-03-04 09:20:03 +0000
The text was updated successfully, but these errors were encountered:
type_defect
| by [email protected]Now that we're moving to docker-compose, we need to consider changing the docker directory name.
See docker/compose#745
By convention, docker-compose is creating containers and networks named after the directory, hence
docker<whatever>
which is likely to cause confusion at best, and collision at worst.We could carefully supply an alternate project name with
-p
everywhere that the docker-compose command line tool is used, but that is hard to maintain, and a volunteer may forget it when running the command manually, creating local damage that will take that developer time to straighten out.We could use the environment variable, but that needs to be set on the host - easy to do with scripts (but with the same maintenance problem), but individual volunteers would need to remember to do this in their host shell or the above bad things could happen to them.
So, we should consider renaming the /docker directory to something like /dt-docker or /docker-dt or maybe /dtdev. (Good bikeshed to talk about here.) Several files under /docker would have to be updated to reflect the result.
Issue migrated from trac:3467 at 2022-03-04 09:20:03 +0000
The text was updated successfully, but these errors were encountered: