Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initialisation freezing on empty primary data. #1016

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Fix initialisation freezing on empty primary data. #1016

wants to merge 8 commits into from
+62 −19

Conversation

staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented Nov 12, 2024 •
edited
Loading

Resolves #981

@staudtMarius staudtMarius self-assigned this Nov 12, 2024
@staudtMarius staudtMarius mentioned this pull request Nov 12, 2024
Open
sebastian-peter
sebastian-peter reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adapted the code a tiny bit. Would be great to have tests for this as well, though, I think.

@sebastian-peter sebastian-peter linked an issue Nov 12, 2024 that may be closed by this pull request
Error handling for invalid time of primary data #981
Open
@danielfeismann
Copy link
Member

danielfeismann commented Nov 13, 2024 •
edited
Loading

Thank you for taking care of this!

One point to discuss, based on the data in vn_simona: Asuming I would increase the simulation start time by one hour from '2011-01-01T00:00:00Z' to 2011-01-01T01:00:00Z, this would cause the exception because time series 8c04e94e-76b0-4369-a55c-f5e1117fb83e has no entry for 01:00:00. But with our general approach we define values as valid until a new one at a certain tick arrise. In my humble opinion this case would be vaild, while some earlier start date (e.g. 2010-12-31T23:00:00Z') wouldn't.

@sebastian-peter
Copy link
Member

One point to discuss, based on the data in vn_simona: Asuming I would increase the simulation start time by one hour from '2011-01-01T00:00:00Z' to 2011-01-01T01:00:00Z, this would cause the exception because time series 8c04e94e-76b0-4369-a55c-f5e1117fb83e has no entry for 01:00:00. But with our general approach we define values as valid until a new one at a certain tick arrise. In my humble opinion this case would be vaild, while some earlier start date (e.g. 2010-12-31T23:00:00Z') wouldn't.

That's a neat idea, however this sounds more complicated and could rather be handled in a new PR? For now I'm quite happy that there's an error message at all

@danielfeismann
Copy link
Member

One point to discuss, based on the data in vn_simona: Asuming I would increase the simulation start time by one hour from '2011-01-01T00:00:00Z' to 2011-01-01T01:00:00Z, this would cause the exception because time series 8c04e94e-76b0-4369-a55c-f5e1117fb83e has no entry for 01:00:00. But with our general approach we define values as valid until a new one at a certain tick arrise. In my humble opinion this case would be vaild, while some earlier start date (e.g. 2010-12-31T23:00:00Z') wouldn't.

That's a neat idea, however this sounds more complicated and could rather be handled in a new PR? For now I'm quite happy that there's an error message at all

Fair point. Yes we should handle that in a new PR

@danielfeismann danielfeismann added the bug Something isn't working label Nov 13, 2024
danielfeismann
danielfeismann reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question I got into my mind

src/main/scala/edu/ie3/simona/service/primary/PrimaryServiceWorker.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

At least 1 approving review is required to merge this pull request.

Assignees

@staudtMarius staudtMarius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handling for invalid time of primary data
3 participants
@staudtMarius @danielfeismann @sebastian-peter