Build failed with GHC 8.8

[felixonmars]

Steps to Reproduce

Build idris with GHC 8.8 (Cabal 3.0)

Expected Behavior

Build passes

Observed Behavior

Setup.hs:356:6: error: Not in scope: ‘preSDist’
    |
356 |    , preSDist = idrisPreSDist
    |      ^^^^^^^^

Setup.hs:357:6: error: Not in scope: ‘sDistHook’
    |
357 |    , sDistHook = idrisSDist (sDistHook simpleUserHooks)
    |      ^^^^^^^^^

Setup.hs:358:6: error: Not in scope: ‘postSDist’
    |
358 |    , postSDist = idrisPostSDist
    |      ^^^^^^^^^

[melted]

The new style builds will not function, because hooks we use are removed and the replacement functionality doesn't work for us: #4757

So you will have to use cabal v1-install. Last I tried, and it was a while ago, the build fell down on dependencies that weren't 8.8 ready. But I guess it's time to sort that out.

[melted]

So, I'm trying again with cabal v1-install --allow-newer

[melted]

Ah, it fails at cheapskate again, not weird as that is unmaintained. I guess we could submit a PR anyway. Or fork it. Or just vendor it. The good news is that regex-base has been fixed.
Fixed it locally and started a build.

[melted]

Ok, and now we get there, hmm, has the sdist hooks been removed for v1 builds too.

Well, that's terrible, that means putting all the files in the cabal files again. And we would have to rename all the test shellscripts because cabal has overly restrictive rules for wildcards: haskell/cabal#5883.

[melted]

To build it's possible to remove the hooks. The dist generation breaks with that, but I guess I can at least fix the compilation errors.

[melted]

#4808

[melted]

Fixed