Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The loading opacity change is breaking #163

Open
MetaChrome opened this issue Dec 21, 2019 · 0 comments
Open

The loading opacity change is breaking #163

MetaChrome opened this issue Dec 21, 2019 · 0 comments
Assignees
@iddan
Labels
bug

Comments

@MetaChrome
Copy link

Hello, the loading opacity merge is not valid. Please revert it. It probably never rerenders with loading=true because handleLoad doesn't cause a shouldComponentUpdate:return true because state is never invalidated.
@iddan iddan self-assigned this Dec 22, 2019
@iddan iddan added the bug label Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iddan iddan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MetaChrome @iddan