Include license files in typed-builder-macro crate #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason not to just copy the files? It's not like they are going to change... |
Not really. Looking at other projects where multiple crates are published from the same repo, using symbolic links just seems to be the standard practice. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the Apache-2.0 and MIT licenses require that (re)distributed sources contain a copy of the original license text. As of right now, the sources published and redistributed via crates.io for the typed-builder-macro crate do not contain license texts.
This PR adds symbolic links that point at the license texts in the project's root directory, which is enough for "cargo package" / "cargo publish" to resolve and include them when publishing to crates.io in most circumstances (unless you're running the "cargo publish" command on Windows, AFAIK).