Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FiniteDiff Opt fails with denoising, 2 dimensions #773

Closed
9 of 10 tasks
PaulTalbot-INL opened this issue Sep 6, 2018 · 2 comments · Fixed by #774
Closed
9 of 10 tasks

FiniteDiff Opt fails with denoising, 2 dimensions #773

PaulTalbot-INL opened this issue Sep 6, 2018 · 2 comments · Fixed by #774

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Sep 6, 2018


Issue Description

If a two-dimensional optimization is performed with at least 2 "numIterPerAve" denoising samples, the first run fails with a "too small dh" error. This appears to be because of an indexing error in choosing the gradient points.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@PaulTalbot-INL
Copy link
Collaborator Author

Does not provide bad results, since it crashes instead.

@alfoa
Copy link
Collaborator

alfoa commented Sep 6, 2018

The issue is a defect but can not cause bad results since it would end up in an error.
No email required...

Closure checklist passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants